Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing gitlab function #4595

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add missing gitlab function #4595

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd5b24d
add missing gitlab function
Aug 5, 2024
f862eba
refactor function
Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions reconcile/utils/gitlab_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,15 @@ def get_access_level(access):
if access == "guest":
return GUEST_ACCESS

def get_group_id_and_projects(self, group_name):
groups = self.gl.groups.list()
group = [g for g in groups if g.path == group_name]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
groups = self.gl.groups.list()
group = [g for g in groups if g.path == group_name]
group = [g for g in self.gl.groups.list() if g.path == group_name]

if not group:
logging.error(group_name + " group not found")
return None, []
[group] = group
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this line?

return group.id, [p.name for p in self.get_items(group.projects.list)]

def get_group(self, group_name: str) -> Group:
gitlab_request.labels(integration=INTEGRATION_NAME).inc()
return self.gl.groups.get(group_name)
Expand Down