[APPSRE-11112] add verify_ondemend_tests for gitlab-housekeeping #4816
Conversation
BumbleFeng
force-pushed
the
ondemand
branch
6 times, most recently
from
48862e2 to
c157a1b
Compare
BumbleFeng
changed the title
BumbleFeng
force-pushed
the
ondemand
branch
7 times, most recently
from
c2bb888 to
88c9c8a
Compare
BumbleFeng
changed the title
reconcile/gitlab_housekeeping.py
Outdated
| gl_fork = GitLabApi( | ||
| instance=gl_instance, | ||
| project_id=mr.source_project_id, | ||
| settings=gl_settings, | ||
| ) |
There was a problem hiding this comment.
any reason to create a new GitLabApi instead of reuse current gl, GitLabApi instance require cleanup.
There was a problem hiding this comment.
The original gl targets the upstream repo while this gl_fork targets the fork repo. We can only get the commit status from the fork repo. I have switch it using with.
There was a problem hiding this comment.
you need this part
qontract-reconcile/reconcile/utils/gitlab_api.py
Lines 128 to 129 in dde29ad
maybe worth extract another method get_project_by_id, and replace prevous project_url part with current get_project. This can save calls used to init GitLabApi, and save those paramter passing of gl_instance and gl_settings.
Also need to make request counter correct as commits.get(commit.id) has 1 request, and .statuses.list() has another (if no pagination), need a better way to count mentioned in https://issues.redhat.com/browse/APPSRE-10450
BumbleFeng
force-pushed
the
ondemand
branch
2 times, most recently
from
ba6c29c to
a164a7f
Compare
Signed-off-by: Feng Huang <fehuang@redhat.com>
allow to check if MR has passed all necessary test jobs and add comments to indicate test results.