fix broken graphql after /reload #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After upgrading the apollo-server-express version, any queries that
include interfaces will fail after reloading the server.
In order to reproduce we can just make a query like this one:
```
{
permissions_v1 (path:"<path>") {
service
... on PermissionGithubOrgTeam_v1 {
org
}
}
}
```
Before reloading the object will contain `org`, but once we reload the
`org` parameter will be missing from the response.
This is because with the new apollo-server-express version besides
resetting the schema on a hot reload, we also need to make sure the
`schemaDerivedData` is also generated.
The solution to this issue was found here:
apollographql/apollo-server#1275 (comment)
Note the `@ts-ignore` line, which is needed because we are accessing a
private method `generateSchemaDerivedData`. Unless we have this line
typescript will raise an error when compiling.
This PR also adds a test that will catch this if there is a regression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading the apollo-server-express version, any queries that include
interfaces will fail after reloading the server.
In order to reproduce we can just make a query like this one:
Before reloading the object will contain
org, but once we reload theorgparameter will be missing from the response.This is because with the new apollo-server-express version besides
resetting the schema on a hot reload, we also need to make sure the
schemaDerivedDatais also generated.The solution to this issue was found here:
apollographql/apollo-server#1275 (comment)
Note the
@ts-ignoreline, which is needed because we are accessing aprivate method
generateSchemaDerivedData. Unless we have this linetypescript will raise an error when compiling.
This PR also adds a test that will catch this if there is a regression.