Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination customization: get last page #633

Closed
rap2hpoutre opened this issue Nov 28, 2018 · 6 comments · Fixed by #1022
Closed

Pagination customization: get last page #633

rap2hpoutre opened this issue Nov 28, 2018 · 6 comments · Fixed by #1022
Labels
good first issue 👋 Issues ideal to start contributing to this repo native 📱 Issues related to React Native version of library web 🕸️ Issues related to Web version of library

Comments

@rap2hpoutre
Copy link
Contributor

Issue Type: enhancement

Platform: web

Description+Screenshots:
Currently, the pagination only displays the N first page (and not the last one) :

capture d ecran 2018-11-28 a 16 12 56

It could be great if we could display something like this (with the last page):

zrjowucfrgwclsvoxhzbdw

Reactivesearch version: 2.11.0

@metagrover metagrover added native 📱 Issues related to React Native version of library good first issue 👋 Issues ideal to start contributing to this repo web 🕸️ Issues related to Web version of library labels Nov 28, 2018
@davidklebanoff
Copy link

davidklebanoff commented Nov 29, 2018

I understand that some websites do this, but can you provide a use case when this would be a desired feature? I can't think of a compelling case, and it seems its presence would harm usability.

@siddharthlatest
Copy link
Member

I second @davidklebanoff's point. What's a good use-case for showing the last page? I think it can be useful for testing purposes, but not anywhere else.

@metagrover
Copy link
Contributor

I'm in favor of having this feature but this should be configurable with a prop (say boolean showLastPage). This stack-exchange post describes the usecase and reasons behind showing the last page button brilliantly - https://ux.stackexchange.com/questions/116448/pagination-what-do-you-need-the-last-page-button-for

@janaka120
Copy link

Any update on this one @rap2hpoutre

@siddharthlatest
Copy link
Member

@janaka120 We haven't added support for this yet, but are open to. Feel free to create a PR, or we will leave this open for now.

@anshumanv
Copy link
Contributor

Picking this up ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue 👋 Issues ideal to start contributing to this repo native 📱 Issues related to React Native version of library web 🕸️ Issues related to Web version of library
Projects
None yet
6 participants