Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enh]: Introduce new prop in ReactiveList to render last pages in pagination [WIP] #1022

Merged
merged 2 commits into from
Aug 12, 2019
Merged

[enh]: Introduce new prop in ReactiveList to render last pages in pagination [WIP] #1022

merged 2 commits into from
Aug 12, 2019

Conversation

anshumanv
Copy link
Contributor

Fixes #633

@anshumanv
Copy link
Contributor Author

Working on some end cases, do lmk if lock file is to be removed.

@siddharthlatest siddharthlatest requested a review from bietkul June 29, 2019 21:35
@bietkul
Copy link
Contributor

bietkul commented Jul 1, 2019

@anshumanv The PR looks good, Can you share some screenshots or gif which showcase the UI and working.

bietkul
bietkul suggested changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@bietkul bietkul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR must be targeted for the next branch.

@anshumanv
Copy link
Contributor Author

Sure @bietkul will share a working gif in a while thanks ✨

@anshumanv anshumanv changed the base branch from dev to next July 1, 2019 09:34
@anshumanv anshumanv changed the base branch from next to dev July 1, 2019 09:34
@bietkul
Copy link
Contributor

bietkul commented Aug 5, 2019

@anshumanv Any update on this?

@anshumanv
Copy link
Contributor Author

start
image

mid
image

end
image

@anshumanv
Copy link
Contributor Author

anshumanv commented Aug 6, 2019 •
edited
Loading

Sorry for the delay, here are some snaps of how it looks.

Seems good to go! 🚀 @bietkul

@siddharthlatest
Copy link
Member

@anshumanv Would the next button be disabled when on the last page? Can you share a GIF showing the transitions?

@bietkul bietkul changed the base branch from dev to next August 6, 2019 14:30
@bietkul bietkul changed the base branch from next to dev August 6, 2019 14:31
@bietkul
Copy link
Contributor

bietkul commented Aug 6, 2019

@anshumanv Can you please port these changes to the next branch, where we're doing the active development.

@anshumanv
Copy link
Contributor Author

Aug-06-2019 20-16-21

@siddharthlatest here, sure @bietkul on it.

@anshumanv anshumanv changed the base branch from dev to next August 6, 2019 14:50
@anshumanv anshumanv changed the base branch from next to dev August 6, 2019 14:50
@anshumanv anshumanv changed the base branch from dev to next August 6, 2019 16:17
@anshumanv
Copy link
Contributor Author

@bietkul changed base

bietkul
bietkul suggested changes Aug 6, 2019
View reviewed changes
Copy link
Contributor

@bietkul bietkul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anshumanv Can you add showEndPage in ReactiveList.ts too?

@anshumanv
Copy link
Contributor Author

anshumanv commented Aug 6, 2019 •
edited
Loading

Ahh forgot about definitions,

@bietkul ptal ✨

@anshumanv
Copy link
Contributor Author

ping @bietkul

@bietkul bietkul merged commit e334059 into appbaseio:next Aug 12, 2019
@anshumanv anshumanv deleted the fix/pagination branch August 12, 2019 17:31
@jyash97 jyash97 mentioned this pull request Aug 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bietkul bietkul bietkul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pagination customization: get last page
3 participants
@anshumanv @bietkul @siddharthlatest