feat: accessibility enhancements in list components #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bietkul
suggested changes
Jul 10, 2019
| {selectAllLabel ? ( | ||
| <li | ||
| key={selectAllLabel} | ||
| className={`${ | ||
| this.state.currentValue[selectAllLabel] ? 'active' : '' | ||
| }`} | ||
| role="option" | ||
| aria-checked={!!this.state.currentValue[selectAllLabel]} | ||
| aria-selected={!!this.state.currentValue[selectAllLabel]} |
There was a problem hiding this comment.
We should avoid code duplication, Can you keep a variable to store !!this.state.currentValue[selectAllLabel], and use it further.
| @@ -469,13 +477,16 @@ class MultiDataList extends Component { | |||
| className={`${ | |||
| this.state.currentValue[item.label] ? 'active' : '' | |||
| }`} | |||
| role="option" | |||
| aria-checked={!!this.state.currentValue[item.label]} | |||
| aria-selected={!!this.state.currentValue[item.label]} | |||
| > | ||
| <Checkbox | ||
| className={ | ||
| getClassName(this.props.innerClass, 'checkbox') || null | ||
| } | ||
| id={`${this.props.componentId}-${item.label}`} | ||
| name={this.props.componentId} | ||
| name={`${this.props.componentId}-${item.label}`} |
There was a problem hiding this comment.
You can use getter to compute the values.
| {selectAllLabel ? ( | ||
| <li | ||
| key={selectAllLabel} | ||
| className={`${ | ||
| this.state.currentValue[selectAllLabel] ? 'active' : '' | ||
| }`} | ||
| role="option" | ||
| aria-checked={!!this.state.currentValue[selectAllLabel]} | ||
| aria-selected={!!this.state.currentValue[selectAllLabel]} |
| @@ -570,13 +576,16 @@ class MultiList extends Component { | |||
| className={`${ | |||
| this.state.currentValue[item.key] ? 'active' : '' | |||
| }`} | |||
| role="option" | |||
| aria-checked={!!this.state.currentValue[item.key]} | |||
| aria-selected={!!this.state.currentValue[item.key]} | |||
| > | ||
| <Checkbox | ||
| className={ | ||
| getClassName(this.props.innerClass, 'checkbox') || null | ||
| } | ||
| id={`${this.props.componentId}-${item.key}`} | ||
| name={this.props.componentId} | ||
| name={`${this.props.componentId}-${item.key}`} |
| {selectAllLabel && ( | ||
| <li | ||
| key={selectAllLabel} | ||
| className={`${ | ||
| this.state.currentValue === selectAllLabel ? 'active' : '' | ||
| }`} | ||
| role="radio" | ||
| aria-checked={this.state.currentValue === selectAllLabel} |
There was a problem hiding this comment.
You can use getter here too.
|
Sure I will do these changes. |
bietkul
suggested changes
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.