Skip to content
This repository has been archived by the owner on Aug 14, 2020. It is now read-only.

Commit

Permalink
spec: pod manifest: volumes: add recursive field
Browse files Browse the repository at this point in the history
The recursive field is a boolean. I set the default to true, but only
with a "SHOULD" (rfc2119):

> 3. SHOULD   This word, or the adjective "RECOMMENDED", mean that there
>    may exist valid reasons in particular circumstances to ignore a
>    particular item, but the full implications must be understood and
>    carefully weighed before choosing a different course.

See discussion on:
#622 (comment)
  • Loading branch information
alban committed Jul 5, 2016
1 parent ae43fe5 commit 5957f48
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion spec/pods.md
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,8 @@ JSON Schema for the Pod Manifest, conforming to [RFC4627](https://tools.ietf.org
"name": "worklib",
"kind": "host",
"source": "/opt/tenant1/work",
"readOnly": true
"readOnly": true,
"recursive": true
}
],
"isolators": [
Expand Down Expand Up @@ -175,6 +176,7 @@ JSON Schema for the Pod Manifest, conforming to [RFC4627](https://tools.ietf.org
* **kind** (string, required) either:
* **empty** - creates an empty directory on the host and bind mounts it into the container. All containers in the pod share the mount, and the lifetime of the volume is equal to the lifetime of the pod (i.e. the directory on the host machine is removed when the pod's filesystem is garbage collected)
* **host** - fulfills a mount point with a bind mount from a **source** directory on the host.
* **recursive** (boolean, optional, only interpreted if **kind** is "host") whether or not the volume will be mounted [recursively](http://lwn.net/Articles/690679/). When **recursive** is not specified, the executor SHOULD default to recursive. However, executors in specific run environment might prefer to default to non-recursive.
* **source** (string, required if **kind** is "host") absolute path on host to be bind mounted under a mount point in each app's chroot.
* **mode** (string, optional, only interpreted if **kind** is "empty", defaults to `"0755"` if unsupplied) indicates the mode permission of the empty volume.
* **uid** (integer, optional, only interpreted if **kind** is "empty", defaults to "0" if unsupplied) indicates the user id that will own the empty volume. Note it is an integer number because each app in the pod would interpret a user name differently.
Expand Down

0 comments on commit 5957f48

Please sign in to comment.