This repository has been archived by the owner on Aug 14, 2020. It is now read-only.
schema: replace bool with *bool in types.Volume. #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please add more context in the commit/PR message about why this is required? This shouldn't be (well, isn't) a Rocket-specific fix. |
By default the `readOnly` field in Volume is `false`, this will cause an app container runtime to always override the image manifest's volume mounts setting. Change it to `*bool` gives us the ability to ignore this field in the container runtime manifest.
|
Sorry :( How does that look now? @jonboulle |
|
@yifan-gu looks perfect! Thanks! |
|
LGTM |
jonboulle
added a commit
that referenced
this pull request
Mar 20, 2015
schema: replace bool with *bool in types.Volume.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix rkt/rkt#615
By default the
readOnlyfield in Volume isfalse, this will causean app container runtime to always override the image manifest's volume
mounts setting. Change it to
*boolgives us the ability to ignore thisfield in the container runtime manifest.