This repository has been archived by the owner on Aug 14, 2020. It is now read-only.
spec: implement os/linux/no-new-privs isolator #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alban @iaguis @jonboulle PTAL |
| "value": true | ||
| ``` | ||
|
|
||
| In the example above, the process will have `no_new_privs` set. If the app's executable has i.e. setuid/setgid bits set they will be ignored. |
There was a problem hiding this comment.
It should say that the default is false.
|
since we generally favour verbosity in the names (e.g. capabilities rather than caps), I wonder if we should call this no-new-privileges ..? |
|
@jonboulle i was thinking back and forth about the longer version, preferred the |
|
gah, typo, I preferred the shorter one ;-) |
This adds a new no-new-privileges isolator type. actool support was added for patching a manifest: `actool patch-manifest -isolators='os/linux/no-new-privileges,true'`. This is a prerequisite for rkt/rkt#1469.
|
@alban @jonboulle I implemented the longer version "no-new-privileges", and addressed review comments, PTAL |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new no-new-privs isolator type.
actool support was added for patching a manifest:
actool patch-manifest -isolators='os/linux/no-new-privs,true'.This is a prerequisite for rkt/rkt#1469.