Skip to content
This repository has been archived by the owner on Aug 14, 2020. It is now read-only.

schema/app: add annotation to set support of sd_notify() #626

Merged
merged 1 commit into from
Jul 13, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions examples/image.json
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,10 @@
{
"name": "homepage",
"value": "https://example.com"
},
{
"name": "appc.io/executor/supports-systemd-notify",
"value": "false"
}
]
}
6 changes: 6 additions & 0 deletions schema/types/annotations_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,12 @@ func TestAnnotationsAssertValid(t *testing.T) {
},
false,
},
{
[]Annotation{
makeAnno("appc.io/executor/supports-systemd-notify", "false"),
},
false,
},
// empty is OK
{
[]Annotation{},
Expand Down
5 changes: 5 additions & 0 deletions spec/aci.md
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,10 @@ JSON Schema for the Image Manifest (app image manifest, ACI manifest), conformin
{
"name": "homepage",
"value": "https://example.com"
},
{
"name": "appc.io/executor/supports-systemd-notify",
"value": false
}
]
}
Expand Down Expand Up @@ -250,6 +254,7 @@ JSON Schema for the Image Manifest (app image manifest, ACI manifest), conformin
* **authors** contact details of the people or organization responsible for the image (freeform string)
* **homepage** URL to find more information on the image (string, must be a URL with scheme HTTP or HTTPS)
* **documentation** URL to get documentation on the image (string, must be a URL with scheme HTTP or HTTPS)
* **appc.io/executor/supports-systemd-notify** (boolean, optional, defaults to "false" if unset) if set to true, the application SHOULD use the sd\_notify mechanism to signal when it is ready. Also it SHOULD be able to detect if the executor had not set up the sd\_notify mechanism and skip the notification without error ([sd_notify()](https://www.freedesktop.org/software/systemd/man/sd_notify.html) from libsystemd does that automatically).

#### Dependency Matching

Expand Down