This repository has been archived by the owner on Aug 14, 2020. It is now read-only.
discovery: add port parameters #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
needs a rebase? |
Currently the ACI spec only supports discovery on ports 443 and 80, this does not allow using a discovery server on any other ports. This commit adds an argument allowing for discovery on arbitrary ports. If the argument is not specified (as in, is 0), the default ports are used.
cgonyeo
force-pushed
the
include-port-discovering
branch
from
ecfdae2 to
b57a2c5
Compare
|
Don't know how I messed that one up. Should build now. |
|
LGTM |
|
I guess we can finally close #110 😁 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the ACI spec only supports discovery on ports 443 and 80, this
does not allow using a discovery server on any other ports.
This commit adds an argument allowing for discovery on arbitrary ports.
If the argument is not specified (as in, is 0), the default ports are
used.
Replaces #110 (comment).
Prompted by appc/acpush#6.