This repository has been archived by the owner on Aug 14, 2020. It is now read-only.
schema: add ppc64le/ppc64 as valid linux archs #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
|
Two wrongs don't make a right, so I would say use ppc64 and ppc64le. |
|
For reference, this is how they are labeled in other places:
Bikeshedding level, may need a tie-breaker. @jonboulle? |
|
I think we should go with @glevand 's suggestion/ |
lucab
force-pushed
the
to-upstream/ppc64-labels
branch
from
7b4b40b to
4e6d9ef
Compare
This adds labeling for the two endian variants of ppc64: `ppc64le` for little-endian and `ppc64` for big-endian. These explicitly correspond to `uname -m` on Linux systems.
lucab
force-pushed
the
to-upstream/ppc64-labels
branch
from
4e6d9ef to
cf3fdbe
Compare
lucab
changed the title
|
Updated to use ppc64le and ppc64. |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds labeling for the two endian variants of ppc64:
ppc64lefor little-endian andppc64for big-endian.These explicitly correspond to
uname -mon Linux systems.