spec: add os/unix/sysctl isolator #647
Conversation
| @@ -383,6 +383,33 @@ Small quantities can be represented directly as decimals (e.g., 0.3), or using m | |||
|
|
|||
| **NOTE**: Network limits MUST NOT apply to localhost communication between apps in a pod. | |||
|
|
|||
| ### Environment Isolators | |||
|
|
|||
| An application or a group of applications may often require some tweaking to the environment where they run, in order to perform in an optimal way. | |||
There was a problem hiding this comment.
Awkward wording I think. I'll suggest "An application may want or need some changes to the system environment it is run in."
At the least, nix often.
|
I tossed on some nits, but I think this makes sense, both in terms of naming and as an isolator. |
| An application or a group of applications may often require some tweaking to the environment where they run, in order to perform in an optimal way. | ||
| Environment isolators take care of setting up the runtime environment as needed. | ||
|
|
||
| #### environment/sysctl |
There was a problem hiding this comment.
Do we want to namespace this more specifically to Linux or *nix? /cc @mpasternacki if he has any thoughts from the BSD perspective
There was a problem hiding this comment.
I checked before venturing here, and at least FreeBSD has sysctl tuning support: https://www.freebsd.org/doc/handbook/configtuning-sysctl.html
There was a problem hiding this comment.
Right, I'm just wondering if that suggests we could make this e.g. os/unix/environment/sysctl
There was a problem hiding this comment.
I'm more or less neutral here and your scoping also makes sense (maybe dropping the environment part). Just for future-proofing: we may have a posix-limits and a linux-limits upcoming after this, how would you scope those too in your mind?
There was a problem hiding this comment.
@lucab I would have expected them to be os/linux/limits and os/posix/limits or similar, per the existing ones.
There was a problem hiding this comment.
Ack, I guess we can settle on os/unix/sysctl - os/unix/limits - os/linux/limits. This is aligned with current naming trend.
|
bump - this still needs a rework right? |
|
It does, plus a decision on #647 (comment) |
lucab
force-pushed
the
to-upstream/sysctl
branch
2 times, most recently
from
2f3b574 to
c76acf6
Compare
lucab
changed the title
This commit introduces an "os/unix/sysctl" isolator, which applies at pod-level.
lucab
force-pushed
the
to-upstream/sysctl
branch
from
c76acf6 to
a00638c
Compare
|
Second iteration of this: renamed isolator to |
|
LGTM |
|
LGTM as well |
This PR introduces an "os/unix/sysctl" isolator, which applies at pod-level.
Closes #645
Arbitrary/controversial choices made here:
new "environment" isolator category, as it can also accommodate "ulimit" ones