This repository has been archived by the owner on Aug 14, 2020. It is now read-only.
CRI: Change CRILabels type to map[string]string. #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yifan-gu
force-pushed
the
cri_label
branch
2 times, most recently
from
7a251d9 to
ea7f7e4
Compare
|
LGTM |
|
@yifan-gu LGTM. This is funny - I was trying to do the right thing by adding validation :-). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow #656 (comment)
Here I see two solutions:
1, use
CRIAnnotationsfor those labels I mentioned in the above comments.2, Merge this PR to allow arbitrary string in labels.
I am fine with both.
/cc @squeed @lucab @s-urbaniak