This repository has been archived by the owner on Aug 14, 2020. It is now read-only.
spec/ace: Add HTTP methods for metadata service #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The metadata service endpoints for creating and verifying an HMAC signature already specify use of the POST method in their descriptions. The other metadata service endpoints make no mention of which HTTP methods are valid for them. The current `rkt` implementation uses POST for the HMAC-related endpoints and GET for all the others. This makes such behaviour explicit in the spec.
|
LGTM, thanks for the clarification |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metadata service endpoints for creating and verifying an HMAC
signature already specify use of the POST method in their
descriptions. The other metadata service endpoints make no mention of
which HTTP methods are valid for them.
The current
rktimplementation uses POST for the HMAC-relatedendpoints and GET for all the others. This makes such behaviour
explicit in the spec.