This repository has been archived by the owner on Aug 14, 2020. It is now read-only.
[issue/690] allow . and - in environment variable names. #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lucab PTAL, taking you up on your offer: rkt/rkt#3532 (comment) |
|
The IEEE spec from which the original conservative character set is taken, as a reference: Editing with a more precise link: http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html |
|
@ae6rt thanks for the PR, can you please also update |
Files touched: schema/types/environment.go, schema/types/environment_test.go, spec/aci.md Allow additional characters in the set considered valid in environment variable names. Prompted by appc/docker2aci#244 and rkt/rkt#3532.
|
I updated spec/aci.md, and rebased. I wanted to honor the desire to adhere to the IEEE spec, so I left the word 'solely' in, with a qualifying clause about the practical desire to allow . and -. I hope it doesn't read strangely. Done. PTAL @lucab |
|
Ping @lucab knowing you are busy, but I don't want to forget about this. |
lucab
approved these changes
Aug 4, 2017
|
LGTM, but I don't have merge powers here. |
cgonyeo
approved these changes
Aug 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files touched: schema/types/environment.go, schema/types/environment_test.go
Allow additional characters in the set considered valid in environment variable names. Prompted by
appc/docker2aci#244 and rkt/rkt#3532.