-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match TestSwarm API version 1.0.0-alpha #3
base: master
Are you sure you want to change the base?
Conversation
Could you update this to actually remove the commented code? Its all versioned, there's no reason to keep it around. Thanks. |
Done |
<option value="beta">Upcoming alphas/betas of popular browsers</option> | ||
<option value="popularbeta">Popular browsers and their upcoming alphas/betas</option> | ||
<option value="default">All available browsers</option> | ||
<option value="currentDesktop">Current release of all major desktop browsers</option> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't make sense anymore - should just convert it to a text input, as the browserSets are now easily customizable for each instance.
Hello, i hope i'm not wrong here with my question. I experience problems in getting the plugin correctly run. The compilation and integration into jenkins worked without bigger problems. Build completed, 4 of 4 Tests without failure. Here is my specific build setup: TestSwarm Server URL: http://localhost/testswarm What i get as a result by clicking save or apply (obviously because no test suite was selected):
|
Changed addjob request to match api (using post, parsing json return to get job id).
Changed test results gathering to match api (parsing json).
Also changed the thresold to get a sucessfull build (if all browsers tests were not ran).
Finaly cleaned the <select> of non present browsers sets.
Java is not my forte so the changes should definitely be checked and improved.
I leaved the old code commented as a reference.
One thing to note, i use the testswarm server url without checking for a tailing slash.