Fix ancestor lookup when using prepended modules #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlconnor
force-pushed
the
fixAncestorLookup
branch
from
bc13197 to
d731353
Compare
tlconnor
force-pushed
the
fixAncestorLookup
branch
2 times, most recently
from
d392793 to
6ac1ea4
Compare
tlconnor
force-pushed
the
fixAncestorLookup
branch
from
6ac1ea4 to
928fcb7
Compare
mqchau
approved these changes
Apr 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
filter_access_permissionsmethod will look up the module ancestor tree callingfilter_access_permissionson each.It previously assumed that
ancestors[0]would always beself, however this has not been the case since the introduction ofprepend.This PR fixes the issue by comparing to
selfinstead of assuming the first ancestor isself.