do not support block handling in element define method [fix #112] #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| define_method name do |&block| | ||
| define_method name do |&block_for_define_method| | ||
| raise ArgumentError, "Cannot pass block to #{name}" if block_for_define_method | ||
|
|
||
| ElementProxy.new(klass, self, options, &block) |
There was a problem hiding this comment.
This is wrong. Before block referenced the variable local to the define_method block, but now it's referencing the parameter to element.
There was a problem hiding this comment.
@dtognazzini oh, yeah, I forgot to remove the &block here
ipmsteven
force-pushed
the
removeElementBlockHandling
branch
2 times, most recently
from
5ee00fd to
05cda3b
Compare
ipmsteven
force-pushed
the
removeElementBlockHandling
branch
3 times, most recently
from
a74476d to
361f85f
Compare
ipmsteven
force-pushed
the
removeElementBlockHandling
branch
from
361f85f to
357c023
Compare
dtognazzini
added a commit
that referenced
this pull request
May 13, 2015
do not support block handling in element define method [fix #112]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.