-
Notifications
You must be signed in to change notification settings - Fork 9
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #104 from gthomas-appfolio/contribDocs
Add contribution guidelines and releasing scripts
- Loading branch information
Showing
3 changed files
with
32 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,3 +8,4 @@ | |
coverage | ||
node_modules | ||
dist | ||
*.log |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
# Contributing Guidelines | ||
|
||
First, thanks for your interest in contributing to `react-gears`—your fellow engineers will greatly appreciate your work! This document outlines some guidelines about how to interact with this codebase. Changes, amendments, and clarifications to this document are always welcome (and encouraged!) Also, these guidelines are heavily borrowed from our own APM Bundle [contribution guidelines](https://github.com/appfolio/apm_bundle/blob/master/CONTRIBUTING.md) and merely add on a workflow for releasing NPM packages. | ||
|
||
## How to make changes | ||
|
||
Start by re-familiarizing yourself with the [contribution guidelines](https://github.com/appfolio/apm_bundle/blob/master/CONTRIBUTING.md) in our main `apm_bundle` repository. Aside from any Ruby/Rails specific items, the committing, testing, and reviewing process is the same here as it is there. Specifically for style, we are using ESLint. Lastly, since this project is small, tests can and should be run locally, but they are also run on CircleCI. | ||
|
||
## How to publish changes | ||
|
||
There are two steps to publish changes that are already tested, reviewed, and merged to master: 1) bumping the version, and 2) publishing. | ||
|
||
### Bumping the Version | ||
|
||
The `react-gears` package follows [semantic versioning](https://docs.npmjs.com/getting-started/semantic-versioning). After assessing the extent of the changes bump the version of the package: | ||
``` | ||
npm version [ major | minor | patch ] | ||
``` | ||
See the [documenation](https://docs.npmjs.com/cli/version) for more details. In a nutshell, this command updates the version in `package.json`, builds the static documentation, and bundles these changes in a commit and tag. | ||
|
||
### Publishing | ||
|
||
The next step is to actually publish the gem, i.e. push it to our NPM repository. After bumping the version simply run publish: | ||
``` | ||
npm publish | ||
``` | ||
This command, pushes the gem to our private repository and pushes the last commits and tags. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters