Merge pull request #201 from appfolio/eslintCleanup

gt - Reduce some eslint errors, fix tests
appfolio · Apr 27, 2017 · 2446a97 · 2446a97
2 parents 0f675b0 + edb99f6
commit 2446a97
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 15 deletions.
diff --git a/src/components/AddressInput.js b/src/components/AddressInput.js
@@ -36,7 +36,7 @@ class AddressInput extends Component {
             name="address1"
             type="text"
             placeholder="Address 1"
-            {...this.propsFor('address1') }
+            {...this.propsFor('address1')}
             state={error.address1 && 'danger'}
             onChange={flow([readEvent, this.onChange])}
             disabled={disabled}
@@ -47,7 +47,7 @@ class AddressInput extends Component {
             name="address2"
             type="text"
             placeholder="Address 2"
-            {...this.propsFor('address2') }
+            {...this.propsFor('address2')}
             state={error.address2 && 'danger'}
             onChange={flow([readEvent, this.onChange])}
             disabled={disabled}
@@ -60,7 +60,7 @@ class AddressInput extends Component {
                 type="text"
                 name="city"
                 placeholder="City"
-                {...this.propsFor('city') }
+                {...this.propsFor('city')}
                 state={error.city && 'danger'}
                 onChange={flow([readEvent, this.onChange])}
                 disabled={disabled}
@@ -74,7 +74,7 @@ class AddressInput extends Component {
                 name="state"
                 placeholder="State"
                 options={US_STATES}
-                {...this.propsFor('state') }
+                {...this.propsFor('state')}
                 onChange={selection => this.onChange({ state: selection && selection.value })}
                 disabled={disabled}
               />
@@ -86,7 +86,7 @@ class AddressInput extends Component {
                 type="text"
                 name="postal"
                 placeholder="Zip"
-                {...this.propsFor('postal') }
+                {...this.propsFor('postal')}
                 state={error.postal && 'danger'}
                 onChange={flow([readEvent, this.onChange])}
                 disabled={disabled}
@@ -100,7 +100,7 @@ class AddressInput extends Component {
             name="countryCode"
             options={COUNTRIES}
             placeholder="Country"
-            {...this.propsFor('countryCode') }
+            {...this.propsFor('countryCode')}
             onChange={selection => this.onChange({ countryCode: selection && selection.value })}
             disabled={disabled}
           />

diff --git a/src/components/Modal.js b/src/components/Modal.js
@@ -1,4 +1,3 @@
-import React from 'react';
 import { Modal } from 'reactstrap';
 
 Modal.defaultProps = {

diff --git a/src/components/Waiting.js b/src/components/Waiting.js
@@ -1,5 +1,4 @@
 import React, { Component } from 'react';
-import { ModalHeader, ModalBody } from 'reactstrap';
 import classnames from 'classnames';
 import Modal from './Modal';
 import Spinner from './Spinner';

diff --git a/test/components/BoundFormRow.spec.js b/test/components/BoundFormRow.spec.js
@@ -5,10 +5,11 @@ import { shallow } from 'enzyme';
 
 import BoundFormRow from '../../src/components/BoundFormRow';
 
+/* eslint-env mocha */
 describe('<BoundFormRow />', () => {
   describe('with context', () => {
-    const onChange = sinon.stub()
-        , onChangeFactory = name => onChange;
+    const onChange = sinon.stub();
+    const onChangeFactory = () => onChange;
 
     const component = shallow(
       <BoundFormRow name="firstName" />, {
@@ -56,8 +57,8 @@ describe('<BoundFormRow />', () => {
   });
 
   describe('with defaults', () => {
-    const onChange = sinon.stub()
-        , onChangeFactory = name => onChange;
+    const onChange = sinon.stub();
+    const onChangeFactory = () => onChange;
     const component = shallow(
       <BoundFormRow name="firstName" />, { context: { onChange: onChangeFactory } }
     );
@@ -73,7 +74,7 @@ describe('<BoundFormRow />', () => {
 
   describe('with onChange prop', () => {
     const spy = sinon.stub();
-    const onChangeFactory = name => data => { spy(`${name} and ${data}`) };
+    const onChangeFactory = name => data => { spy(`${name} and ${data}`); };
     const onChange = sinon.stub();
 
     const component = shallow(

diff --git a/test/components/Waiting.spec.js b/test/components/Waiting.spec.js
@@ -6,7 +6,7 @@ import assert from 'assert';
 import { mount } from 'enzyme';
 import { Modal, Spinner, Waiting } from '../../src';
 
-describe.only('<Waiting />', () => {
+describe('<Waiting />', () => {
   it('should render a modal', () => {
     const wrapper = mount(<Waiting />);
     const modal = wrapper.find(Modal);
@@ -26,7 +26,6 @@ describe.only('<Waiting />', () => {
 
   it('uses passed in children', () => {
     const wrapper = mount(<Waiting isOpen backdrop><div id="yo">YO...</div></Waiting>);
-    console.log(wrapper.find('#yo').exists());
     assert.equal(false, wrapper.find(Spinner).exists());
   });