Merge pull request #20 from gthomas-appfolio/cleanUpSomeLint

ap - fix some lint errors
appfolio · Oct 13, 2016 · dde4001 · dde4001
2 parents ee60cc7 + 460c708
commit dde4001
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 16 deletions.
diff --git a/src/components/FormChoice.js b/src/components/FormChoice.js
@@ -13,16 +13,16 @@ const FormChoice = props => {
     ...attributes
   } = props;
 
-  const labelClasses = classname({ 'form-check-inline': inline })
-      , item = (
-        <Label className={labelClasses} check={!inline}>
-          <Input type={type} {...attributes} disabled={disabled} />
-          <span children={children} />
-        </Label>
-      );
+  const labelClasses = classname({ 'form-check-inline': inline });
+  const item = (
+    <Label className={labelClasses} check={!inline}>
+      <Input type={type} {...attributes} disabled={disabled} />
+      <span children={children} />
+    </Label>
+  );
 
   if (type === 'select') {
-    return <option {...attributes} children={children} />
+    return <option {...attributes} children={children} />;
   } else if (inline) {
     return item;
   } else {
@@ -31,9 +31,10 @@ const FormChoice = props => {
         check
         color={color || state}
         disabled={disabled}
-        children={item} />
+        children={item}
+      />
     );
   }
-}
+};
 
 export default FormChoice;
diff --git a/src/components/FormRow.js b/src/components/FormRow.js
@@ -26,13 +26,16 @@ const FormRow = props => {
       ...attributes
     }));
   } else if (type === 'static') {
-    content = <Input static
+    content = (
+      <Input
+        static
         id={id}
         children={props.value || props.defaultValue}
         size={size}
         state={color || state}
         {...attributes}
       />
+    );
   } else {
     const InputElement = (typeof type === 'string') ? Input : type;
     content = (
@@ -50,13 +53,13 @@ const FormRow = props => {
   return (
     <FormGroup row color={color || state}>
       <Label for={id} sm={3} size={size}>
-        { label }
-        { required && label ? <span className="text-danger"> *</span> : null }
+        {label}
+        {required && label ? <span className="text-danger"> *</span> : null}
       </Label>
       <Col sm={9}>
-        { content }
-        { hint ? <FormText color="muted" children={hint} /> : null }
-        { feedback ? <FormFeedback children={feedback} /> : null }
+        {content}
+        {hint ? <FormText color="muted" children={hint} /> : null}
+        {feedback ? <FormFeedback children={feedback} /> : null}
       </Col>
     </FormGroup>
   );

diff --git a/src/components/PatternInput.js b/src/components/PatternInput.js
@@ -11,4 +11,8 @@ const PatternInput = ({ pattern, ...props }) => (
   <Input {...props} onKeyPress={pattern ? e => restrictKeystrokeTo(e, pattern) : null} />
 );
 
+PatternInput.propTypes = {
+  pattern: React.PropTypes.object
+}
+
 export default PatternInput;