Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEE-610] update uuid from v8 to v9 #1252

Merged
merged 1 commit into from
Aug 20, 2024
Merged

[FEE-610] update uuid from v8 to v9 #1252

merged 1 commit into from
Aug 20, 2024

Conversation

mdalpozzo
Copy link
Contributor

@mdalpozzo mdalpozzo commented Aug 15, 2024

this will help to address an issue with jest >28 by default expects cjs exports in browser env. This will prevent other repos that use react-gears and run tests with jest >28 from encountering this issue with the "uuid" package.

https://jest-archive-august-2023.netlify.app/docs/28.x/upgrading-to-jest28/#packagejson-exports

https://github.com/uuidjs/uuid/blob/main/CHANGELOG.md#900-2022-09-05
see: "add Jest/jsdom compatibility" in changelog
uuidjs/uuid#642

this will help to address an issue with jest >28 by default expects cjs exports in browser env
https://jest-archive-august-2023.netlify.app/docs/28.x/upgrading-to-jest28/#packagejson-exports
https://github.com/uuidjs/uuid/blob/main/CHANGELOG.md#900-2022-09-05
see: "add Jest/jsdom compatibility" in changelog

- this commit also removes test/jest resolver.js file which only existed to resolve the jest cjs browser issue
Copy link
Contributor

Released prerelease version 8.13.2-update-uuid-cf28291.0.
You may now run npm install @appfolio/react-gears@update-uuid

@mdalpozzo mdalpozzo marked this pull request as ready for review August 19, 2024 18:08
@mdalpozzo mdalpozzo requested a review from a team August 19, 2024 18:13
@mdalpozzo mdalpozzo changed the title chore: update uuid from v8 to v9 [FEE-610] update uuid from v8 to v9 Aug 19, 2024
@Brian-Holland Brian-Holland merged commit 6790e2f into master Aug 20, 2024
4 checks passed
@Brian-Holland Brian-Holland deleted the update-uuid branch August 20, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants