Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix react-select focus issue #175

Merged
merged 1 commit into from
Mar 17, 2017
Merged

Conversation

tlconnor
Copy link
Contributor

@tlconnor tlconnor commented Mar 16, 2017

There is a bug in react-select where the currently selected item will lose focus if the options list changes, even if the selected option still exists.

There is a PR to fix this on react-select JedWatson/react-select#1512 but the author does not seem to be very resposive to PRs.

In the meantime this PR takes the fix and applies it directly within react-gears. This is intended as a temporary fix until the real one gets merged.

Before:
screen shot 2017-03-16 at 3 11 52 pm

After:
screen shot 2017-03-16 at 3 10 15 pm

@tlconnor tlconnor force-pushed the fixSelectFocusIssue branch 2 times, most recently from ef2dfdb to 642e600 Compare March 16, 2017 21:08
@tlconnor tlconnor force-pushed the fixSelectFocusIssue branch from 642e600 to c761327 Compare March 16, 2017 22:37
@tlconnor
Copy link
Contributor Author

JedWatson/react-select#1512 has been merged to react-select, but we have no idea when the next release might be so I'd suggest we still go ahead with this fix.

@gthomas-appfolio gthomas-appfolio merged commit 4652583 into master Mar 17, 2017
@gthomas-appfolio
Copy link
Contributor

Sounds good, thanks for the fix

@phwebi phwebi deleted the fixSelectFocusIssue branch January 29, 2020 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants