gt - Refactor CreditCard components #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gthomas-appfolio
commented
Apr 13, 2017
gthomas-appfolio
commented
- Remove CreditCardForm in lieu of defining in app
- Adjust responsive layout, remove gutters
- Remove labels in component in lieu of defining in app
- Combine stories under CreditCardInput
- Add story knobs
- Remove CreditCardForm in lieu of defining in app - Adjust responsive layout, remove gutters - Remove labels in component in lieu of defining in app - Combine stories under CreditCardInput - Add story knobs
|
|
balloob
approved these changes
Apr 13, 2017
|
My only concern with this component is that there are no labels, but I guess that's a feature improvement for the next version. This looks great |
|
Yeah, it's something that I realized with this PR - we should likely make a label option somehow as MyCase adopts. Placeholders seem okay for first pass but I'll definitely make an issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.