Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm: restyle react-select internals for better cursor position #187

Merged
merged 2 commits into from
Apr 17, 2017
Merged

rm: restyle react-select internals for better cursor position #187

merged 2 commits into from
Apr 17, 2017

Conversation

robertmaloney
Copy link
Contributor

Old:
image

New:
image

There shouldn't be any noticeable changes in other cases.

phwebi
phwebi reviewed Apr 17, 2017
View reviewed changes
src/components/Select.scss Outdated
@@ -15,11 +15,12 @@
// component. By reducing this to 5px the input looks more natural and the cursor does not
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the comment?

@gthomas-appfolio
Copy link
Contributor

Thanks for fixing, LGTM

@gthomas-appfolio gthomas-appfolio merged commit 3a9a9e7 into master Apr 17, 2017
@gthomas-appfolio gthomas-appfolio deleted the fix-react-select-input branch April 17, 2017 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phwebi phwebi phwebi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertmaloney @gthomas-appfolio @phwebi