Add feature banner to react-gears #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronpanch
suggested changes
Apr 21, 2017
src/components/FeatureBanner.js
Outdated
| const alertStyle = `${styles.alert} font-weight-bold text-uppercase`; | ||
|
|
||
| return ( | ||
| <div> |
There was a problem hiding this comment.
Do we need this wrapper?
src/components/FeatureBanner.js
Outdated
| {alertText} | ||
| </div> | ||
| <div className={`${styles.body} d-flex align-items-around justify-content-start mr-auto`}> | ||
| <div className={`${styles.info}`}> |
There was a problem hiding this comment.
Do we need to interpolate here?
aaronpanch
reviewed
Apr 21, 2017
src/components/FeatureBanner.js
Outdated
| return ( | ||
| <div> | ||
| <Alert color="info" className="align-items-center d-flex flex-wrap"> | ||
| <div className={`${alertStyle} pr-3 hidden-sm-down`}> |
aaronpanch
reviewed
Apr 21, 2017
src/components/FeatureBanner.scss
Outdated
| .body { | ||
| @media (min-width: 768px) { | ||
| border-left: 1px solid #dae4f1; | ||
| padding-left: 13px; |
There was a problem hiding this comment.
Where did this come from?
aaronpanch
reviewed
Apr 21, 2017
src/components/FeatureBanner.scss
Outdated
| @@ -0,0 +1,15 @@ | |||
| .body { | |||
| @media (min-width: 768px) { | |||
| border-left: 1px solid #dae4f1; | |||
There was a problem hiding this comment.
Where did this color come from?
JingyuZ
force-pushed
the
cpFeatureBanner
branch
from
fc076e7 to
21c0635
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.