Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add expandable card container [Deliver: #143170825] #200

Merged
merged 8 commits into from
May 8, 2017
Merged

Add expandable card container [Deliver: #143170825] #200

merged 8 commits into from
May 8, 2017

Conversation

shiboying
Copy link
Contributor

@shiboying shiboying force-pushed the AddExpandableCardContainer branch from 248d960 to db8dbe2 Compare April 27, 2017 00:45
@gthomas-appfolio
gt - Move CardContainer to BlockPanel
7ef2e28 
- Rename CardContainer to BlockPanel
- Update interface
- Increase themeability
@gthomas-appfolio
gt - Update tests
cd2ea79
@gthomas-appfolio gthomas-appfolio requested a review from tlconnor May 8, 2017 23:20
tlconnor
tlconnor approved these changes May 8, 2017
View reviewed changes
Copy link
Contributor

@tlconnor tlconnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good. Thanks for getting onto this.

@gthomas-appfolio gthomas-appfolio merged commit 51f732c into master May 8, 2017
@gthomas-appfolio gthomas-appfolio deleted the AddExpandableCardContainer branch May 8, 2017 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlconnor tlconnor tlconnor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shiboying @tlconnor @gthomas-appfolio