Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak test imports #250

Merged
merged 2 commits into from
Jun 30, 2017
Merged

Tweak test imports #250

merged 2 commits into from
Jun 30, 2017

Conversation

balloob
Copy link

@balloob balloob commented Jun 29, 2017

  • Tweak all tests to import from our entry point. This better mimics how our consumers consume. Also will make it easier for me to run the tests against a Rollup build 👍
  • Add missing exported components to src/index.js
  • Replace inline ESLint guidance to use mocha syntax with .eslintrc file at root of test dir
  • 13 of the files would register for jsdom-global on their own. I instead opted for a mocha option to auto-register it before each file. This allows us to run any test file individually
  • Move mocha options to test/mocha.opts so that one can run NODE_ENV=test mocha and it works 👍

@gthomas-appfolio
Copy link
Contributor

Looks good, thanks man

@gthomas-appfolio gthomas-appfolio merged commit 4020d6b into master Jun 30, 2017
@gthomas-appfolio gthomas-appfolio deleted the update-tests branch June 30, 2017 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants