gt - Add onBlur prop to DateInput #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
reviewed
Jul 7, 2017
src/components/DateInput.js
Outdated
| const date = parse(value, this.props.dateFormat); | ||
|
|
||
| if (date) { | ||
| this.props.onBlur(date, true); |
There was a problem hiding this comment.
This is weird. Why would we pass any of the value to onBlur ? This feels like API creep to me.
There was a problem hiding this comment.
This is to allow simulating the previously-used react-widgets date picker which clears on blur if invalid. With this, it allows an (optional) hook to allow that can easily duplicate , but without adding that fairly specific "clearOnInvalid" behavior.
balloob
approved these changes
Jul 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.