Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm: send undefined by default to prevent clearable UI for empty string #259

Closed
wants to merge 1 commit into from
Closed

rm: send undefined by default to prevent clearable UI for empty string #259

wants to merge 1 commit into from

Conversation

robertmaloney
Copy link
Contributor

PR does two things:

  • upgrades react-select to 1.0.0-rc.5
  • fixes a bug where it looks like you can clear on a empty select field

Before:
image

After:
image

balloob
balloob reviewed Jul 11, 2017
View reviewed changes
package.json Outdated
@@ -32,14 +32,14 @@
"credit-card-type": "^5.0.1",
"date-fns": "^1.28.5",
"fecha": "^2.3.0",
"lodash.clonedeep": "^4.5.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this change.

@gthomas-appfolio gthomas-appfolio mentioned this pull request Jul 12, 2017
Merged
@robertmaloney robertmaloney deleted the react-select-rc5 branch July 12, 2017 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balloob balloob balloob left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertmaloney @balloob