Allow form row labels to be optional #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/components/FormRow.js
Outdated
| {label} | ||
| {required && label ? <span className="text-danger"> *</span> : null} | ||
| </Label> | ||
| {label !== false && ( |
There was a problem hiding this comment.
Thanks, would this be better to just not display if no label? E.g. {label &&
There was a problem hiding this comment.
Good point, fixed.
tlconnor
force-pushed
the
optional-form-row-label
branch
from
6abe45b to
07022a2
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to pass
label={false}toFormRowcomponents, preventing the component from rendering a label.This is useful for inputs within tables where the table header is used instead of a label.
For example in the screenshot below the
Accountcolumn usesFormRowto make use of the field level error handling but does not need a label for each input.