Update Steps #301
Merged
Update Steps #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add responsive labels - Add `collapse` props to force show or hide equivalent responsive labels - Add unit tests
Now uses `currentColor` and `.text-success` for theming
phwebi
reviewed
Sep 19, 2017
src/components/Steps.js
Outdated
| ); | ||
| }; | ||
|
|
||
| Steps.propTypes = { | ||
| collapse: PropTypes.bool, |
There was a problem hiding this comment.
should we give collapse a default value?
There was a problem hiding this comment.
Thanks for noticing, Paulus and I discussed that we could default to responsive behavior (collapse on < sm) if this prop is not present. True or false would force collapse or expanded labels respectively.
src/components/Steps.js
Outdated
| ); | ||
| }; | ||
|
|
||
| Steps.propTypes = { | ||
| collapse: PropTypes.bool, | ||
| complete: PropTypes.bool, |
There was a problem hiding this comment.
any reason why complete and step aren't required?
There was a problem hiding this comment.
Complete is only required if done, but good point on step... maybe that should required. Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the Step component to add responsive labels, and ability to force the corresponding collapsed or uncollapsed labels. Showing collapsed:
This also removes 3 hardcoded colors in lieu of using bootstrap
text-primaryandtext-successclasses for better theming