Update DateMonth #303
Merged
Update DateMonth #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move DateMonth -> MonthInput using same code as DateInput - Add tests
|
This PR removes the DateMonth component and replaces with MonthInput, which uses the same interface and behavior as DateInput:
|
balloob
reviewed
Sep 22, 2017
src/components/MonthCalendar.js
Outdated
|
|
||
| import styles from './MonthCalendar.scss'; | ||
|
|
||
| function range(start, end) { |
There was a problem hiding this comment.
We could share this in a util folder potentially
balloob
reviewed
Sep 22, 2017
src/components/MonthCalendar.js
Outdated
| const { format } = Fecha; | ||
|
|
||
| const Label = ({ selected, label, onClick, visible = true }) => ( | ||
| <li className={`px-0 py-1 text-center ${selected ? 'bg-primary text-white' : ''} ${!visible ? 'invisible' : ''}`} onClick={onClick}> |
There was a problem hiding this comment.
balloob
reviewed
Sep 22, 2017
| .picker { | ||
| min-width: 16em; | ||
| li { | ||
| cursor: pointer; |
There was a problem hiding this comment.
can be removed once we're using buttons.
There was a problem hiding this comment.
Cool thanks, will check this out
There was a problem hiding this comment.
I will mark as TODO for the release, after looking at it am porting markup used in app that had various tweaks to ensure we can click without dead areas, overlap, etc., and started re-introducing issues when I added links.
We should/will update this, will also create issue.
- Add TODO for Month labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, will update with more info on changes