Replace AddressInput Selects #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
reviewed
Oct 27, 2017
| @@ -2,21 +2,13 @@ import PropTypes from 'prop-types'; | |||
| import React from 'react'; | |||
| import flow from 'lodash.flow'; | |||
|
|
|||
| import Select from './Select'; | |||
| import CountryInput from './CountryInput'; | |||
There was a problem hiding this comment.
I like this a lot as it allows us to even improve the looks over time.
balloob
reviewed
Oct 27, 2017
| @@ -2,21 +2,13 @@ import PropTypes from 'prop-types'; | |||
| import React from 'react'; | |||
| import flow from 'lodash.flow'; | |||
|
|
|||
| import Select from './Select'; | |||
| import CountryInput from './CountryInput'; | |||
| import StateInput from './StateInput'; | |||
There was a problem hiding this comment.
The name is slightly ambiguous. Should we call it USAStateInput ?
There was a problem hiding this comment.
True, idea was it might handle determining provinces for various countries, but agreed "State" is vague
balloob
approved these changes
Oct 27, 2017
buronnie
reviewed
Oct 27, 2017
| @@ -6,7 +6,7 @@ export default [ | |||
| { label: 'California', value: 'CA' }, | |||
| { label: 'Colorado', value: 'CO' }, | |||
| { label: 'Connecticut', value: 'CT' }, | |||
| { label: 'Deleware', value: 'DE' }, | |||
| { label: 'Delaware', value: 'DE' }, | |||
- Reorder countries for common usage - Correct State typo - Add other US state codes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to replace AddressInput Select with Input type="select"
Adds CountryInput and StateInput
WIP - need to: