Add class to Select component when in Async mode for testing #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/components/Select.js
Outdated
| @@ -19,6 +21,7 @@ class Select extends React.Component { | |||
| }; | |||
|
|
|||
| static defaultProps = { | |||
| className: '', | |||
There was a problem hiding this comment.
If using classNames I think you can skip the default value of ''
src/components/Select.js
Outdated
| @@ -51,6 +54,8 @@ class Select extends React.Component { | |||
| const { value, ...props } = this.props; | |||
There was a problem hiding this comment.
You can instead do:
const { className, value, ...props } = this.props;
and remove the delete below
src/components/Select.js
Outdated
| @@ -51,6 +54,8 @@ class Select extends React.Component { | |||
| const { value, ...props } = this.props; | |||
| delete props.onChange; // don't pass onChange prop to react-select | |||
| const SelectElement = this.props.loadOptions ? ReactSelect.Async : ReactSelect; | |||
| const className = classNames(this.props.className, {'js-SelectAsync': this.props.loadOptions}); | |||
There was a problem hiding this comment.
could we rename something more generic like select-async, etc as this will help if we rewrite or replace with React Select
src/components/Select.js
Outdated
| @@ -51,6 +54,8 @@ class Select extends React.Component { | |||
| const { value, ...props } = this.props; | |||
| delete props.onChange; // don't pass onChange prop to react-select | |||
| const SelectElement = this.props.loadOptions ? ReactSelect.Async : ReactSelect; | |||
| const className = classNames(this.props.className, {'js-SelectAsync': this.props.loadOptions}); | |||
| delete props.className; | |||
This would simplify testing when this component is used in selenium tests. We can wait for the result set to be loaded, but doing so would require that change to made in every place this is being used in tests. Adding this class would allow the page object to be able to check itself and every test would benefit automatically.
zldavis
force-pushed
the
zdAddSelectAsyncClass
branch
from
fcd7110 to
47d963d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would simplify testing when this component is used in selenium tests. We can wait for the result set to be loaded, but doing so would require that change to made in every place this is being used in tests. Adding this class would allow the page object to be able to check itself and every test would benefit automatically.