Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gt - Correct bundle export as umd #35

Merged
merged 1 commit into from
Nov 1, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 12 additions & 53 deletions dist/bundle.js

Large diffs are not rendered by default.

5 changes: 2 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,17 +1,16 @@
{
"name": "xanthous",
"version": "0.1.0",
"description": "",
"description": "React-based version of Gears",
"author": "Appfolio, Inc.",
"license": "MIT",
"main": "dist/bundle.js",
"files": ["dist"],
"scripts": {
"dist": "webpack -p",
"lint": "eslint src; exit 0",
"start": "webpack-dashboard -- node dev_server.js",
"start": "start-storybook -p 6006",
"test": "nyc --reporter text --reporter lcov mocha --recursive --timeout 10000 --compilers js:babel-register --require ignore-styles",
"storybook": "start-storybook -p 6006",
"build-storybook": "build-storybook"
},
"dependencies": {
Expand Down
8 changes: 4 additions & 4 deletions src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,13 +65,13 @@ import {

// Gears:

import Address from './components/Address.js';
//import Address from './components/Address.js';
import Alert from './components/Alert.js';
import BlockPanel from './components/BlockPanel.js';
import CurrencyInput from './components/CurrencyInput.js';
import Datapair from './components/Datapair.js';
import DateMonth from './components/datemonth/DateMonth.js';
import Dropdown2 from './components/Dropdown2.js';
//import Dropdown2 from './components/Dropdown2.js';
import Flag from './components/Flag.js';
import FormChoice from './components/FormChoice.js';
import FormRow from './components/FormRow.js';
Expand Down Expand Up @@ -154,14 +154,14 @@ export {
CurrencyInput,
Datapair,
DateMonth,
Dropdown2, // TODO temp
// Dropdown2, // TODO temp
Flag,
FormChoice,
FormRow,
HelpBubble,
Icon, // TODO alias is visible in example code?
PatternInput,
Address,
// Address,
// SummaryBox,
// SummaryBoxItem
// UnitPropertyCard TODO
Expand Down
5 changes: 4 additions & 1 deletion webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,10 @@ module.exports = {
],
output: {
path: path.resolve(__dirname, './dist'),
filename: 'bundle.js'
filename: 'bundle.js',
library: 'xanthous',
libraryTarget: 'umd',
umdNamedDefine: true
},
module: {
loaders: [
Expand Down