Add support for passing errors to HasManyFields component #377
Conversation
| @@ -108,6 +110,7 @@ class HasManyFields extends React.Component { | |||
| > | |||
| <Template | |||
| value={item} | |||
| errors={errors[i]} | |||
There was a problem hiding this comment.
Just double-checking that if we don't use errors, this will not pass errors to child components that don't support errors prop
There was a problem hiding this comment.
Not sure if I misunderstood, but if the child components don't support errors prop, then this will just be ignored. Or do you mean we should only pass errors along to the child components if errors prop was actually passed in to the HasManyFields component?
There was a problem hiding this comment.
Sort of, otherwise you'll get prop errors in console.
But in this case, if no errors are specified, the errors prop will be passed undefined, which I think is okay
There was a problem hiding this comment.
Yea that was my thinking. If no errors prop is specified, the prop will be passed as undefined, which I believe React treats as not having the prop passed at all. If errors are specified, then the prop will get passed with an actual value, but I imagine people would only pass in errors if their template supports that prop
No description provided.