gt - Form label group additions #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choruk
approved these changes
Apr 5, 2018
| stacked, | ||
| width | ||
| } = props; | ||
|
|
||
| const rowColor = color || (invalid && 'danger'); |
There was a problem hiding this comment.
I added the invalid prop because I wasn't sure whether we wanted to include the FormFeedback piece, but I do agree that it makes sense to have that. As a result, I think we can get rid of the invalid prop and just change this check from:
const rowColor = color || (invalid && 'danger');to:
const rowColor = color || (feedback && 'danger');There was a problem hiding this comment.
Makes sense. My view on including the form feedback and hint is I'd like to see this as a general purpose component that can be used in place of FormRow. This helps by doing all the various feedback, etc in the correct place and tweaks, just without the FormRow 'magic' of type, state, value stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.