gt - Update HMF Tooltip #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works around disabledReason Tooltip not showing up on disabled delete button, by showing a Button with `disabled` className and no onClick if disabled
sveinn
reviewed
May 24, 2018
src/components/HasManyFieldsRow.js
Outdated
| id={this.id} | ||
| color="danger" | ||
| outline | ||
| className="p-2 disabled" |
There was a problem hiding this comment.
onClick={e => e.preventDefault()} ?
- Prevent default for disabled onClick - Update story
sveinn
reviewed
May 24, 2018
| @@ -26,6 +26,7 @@ storiesOf('HasManyFields', module) | |||
| onDelete={action('onDelete')} | |||
| disabled={boolean('disabled', false)} | |||
| disabledReason={text('disabledReason')} | |||
| disabledReasonPlacement={select('placement', ['top', 'left', 'bottom', 'right'], 'top')} | |||
sveinn
approved these changes
May 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works around disabledReason Tooltip not showing up on disabled delete button, by showing a Button with
disabledclassName and no onClick if disabled."Why not just do a no-op on ConfirmationButton onClick?"
Because the ConfirmationButton has it's own onClick to show "Delete" confirmation message and can only be disabled with the
disabledattribute (which then breaks Tooltips..)