gt - WIP UncontrolledTable #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gthomas-appfolio
commented
Aug 10, 2018
gthomas-appfolio
commented
- Name is temp, maybe combine with Table
mjewell
reviewed
Aug 27, 2018
src/components/UncontrolledTable.js
Outdated
| [...selected, value]; | ||
|
|
||
| this.setState({ selected: newSelection }, | ||
| this.props.onSelect(newSelection) |
There was a problem hiding this comment.
Should this be a callback?
mjewell
approved these changes
Aug 27, 2018
src/components/UncontrolledTable.js
Outdated
| const { page, sort } = this.state; | ||
| const { ascending, column } = sort; | ||
| const { columns, expandable, pageSize, paginated, rowClassName, rowExpanded, rows, selectable, onSelect, ...props } = this.props; | ||
| const cols = columns.map(col => (col.sortable !== false) ? |
There was a problem hiding this comment.
can you just do col.sortable here?
There was a problem hiding this comment.
It looks odd, but am supporting a "default" of sortable == true, without it actually being set to true. This explicitly checks for false.
src/components/UncontrolledTable.js
Outdated
| type="checkbox" | ||
| className="mx-1" | ||
| checked={this.allSelected} | ||
| onChange={() => this.toggleAll()} |
There was a problem hiding this comment.
this can just be this.toggleAll
| assert.equal(ths.length, columns.length + 1); // For selectable column | ||
| }); | ||
|
|
||
| it('should call onSelect when selectable row picked'); |
There was a problem hiding this comment.
Is there something we need to wait for for these tests?
There was a problem hiding this comment.
No, just getting up to speed with enzyme 3 test changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.