new component TextCollapseByLength #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mqchau
force-pushed
the
nilTextCollapseByLength
branch
from
65e846f to
49a7e2d
Compare
- Rename to CollapsableText, similar to ExpandableSection - Rename showMore/showLess to moreLabel/lessLabel to avoid sounding like an action - Rename shouldShowAll & collapsedByDefault to collapse so that we can use as controlled prop. - Update propTypes - Use ellipsis - Some minor eslint warnings
gthomas-appfolio
approved these changes
Sep 14, 2018
joelbandi
reviewed
Sep 27, 2018
| } else if (this.state.collapsed) { | ||
| return ( | ||
| <span> | ||
| {children.substring(0, maxLength).trim()}… {this.renderButton(this.expandText, moreLabel)} |
There was a problem hiding this comment.
this.expandText would be undefined
joelbandi
reviewed
Sep 27, 2018
|
|
||
| return ( | ||
| <span> | ||
| {children} {this.renderButton(this.collapseText, lessLabel)} |
There was a problem hiding this comment.
this.collapseText would be undefined
joelbandi
reviewed
Sep 27, 2018
| this.setState({ collapsed: !this.state.collapsed }); | ||
| }; | ||
|
|
||
| renderButton(callback, buttonText) { |
There was a problem hiding this comment.
Is the callback being used here? we're using toggle() anyway.
There was a problem hiding this comment.
Seems reasonable, can you create a PR to correct them?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This component will let us show more or less of a long piece of text