Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ap - fix help bubble icon #99

Merged
merged 1 commit into from
Jan 18, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/HelpBubble.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ class HelpBubble extends React.Component {

return (
<span className={className} style={style}>
<Icon name="question-sign" onClick={this.toggle} id={this.id} />
<Icon name="question-circle" onClick={this.toggle} id={this.id} />
<Popover isOpen={this.state.isOpen} toggle={this.toggle} target={this.id} {...other}>
<PopoverTitle children={title} />
<PopoverContent children={children} />
Expand Down
2 changes: 1 addition & 1 deletion test/components/HelpBubble.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import HelpBubble from '../../src/components/HelpBubble';
describe('<HelpBubble />', () => {
it('should have a question mark', () => {
const icon = mount(<HelpBubble title="hello" />).find(Icon);
assert.equal(icon.prop('name'), 'question-sign');
assert.equal(icon.prop('name'), 'question-circle');
});

it('should link popover and icon trigger', () => {
Expand Down