Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: show name in resolve-name-status table #567

Merged
merged 5 commits into from
Jun 24, 2024

Conversation

kajes
Copy link
Contributor

@kajes kajes commented Jun 24, 2024

This PR is an update for the resolve-name-status command. The update includes showing the resolved name in the table presented instead of only in the json output.

Partial resolutions are excluded from the table by default to not clutter the output, but can be shown using the --partial-resolutions

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 24, 2024
Copy link
Contributor

@thomascellerier thomascellerier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this API is changing quite a lot in 6.4 so sdpctl will need to be updated to handle the differences in API version 21.

The new format is as follows (in python dataclasses terms):

@dataclass
class NameResolution:
    ips: list[str]
    errors: list[str]


@dataclass
class NamesStatusResponse:
    resolutions: dict[str, NameResolution]

@kajes
Copy link
Contributor Author

kajes commented Jun 24, 2024

Note that this API is changing quite a lot in 6.4 so sdpctl will need to be updated to handle the differences in API version 21.

The new format is as follows (in python dataclasses terms):

@dataclass
class NameResolution:
    ips: list[str]
    errors: list[str]


@dataclass
class NamesStatusResponse:
    resolutions: dict[str, NameResolution]

Alright, I'll make sure it gets an update by then 👍

@kajes kajes merged commit 318119d into main Jun 24, 2024
4 checks passed
@kajes kajes deleted the SA-23852-show-name-in-resolve-name-status branch June 24, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Development

Successfully merging this pull request may close these issues.

2 participants