Allow for multiple sets of possible required parameters #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -69,23 +69,43 @@ function checkParams (paramSets, jsonObj) { | |||
| // some clients pass in an element id in the params | |||
| optionalParams.push('id'); | |||
|
|
|||
| // if we have no required parameters, all is well | |||
There was a problem hiding this comment.
This block of code could be moved up a couple lines to line 65, couldn't it? Because we don't care about setting up optional params if there are no required params.
|
One comment, otherwise good. Yay for more tests :) |
imurchie
force-pushed
the
isaac-params
branch
from
38a33c4 to
d246716
Compare
imurchie
force-pushed
the
isaac-params
branch
from
d246716 to
5947967
Compare
imurchie
added a commit
that referenced
this pull request
Jan 22, 2016
Allow for multiple sets of possible required parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were cases where two or more different sets of required parameters could be passed in, which caused a failure.
See appium/java-client#302