Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make sure the test is never going to be unexpectedly interrupted #664

Merged
merged 5 commits into from
Feb 22, 2023

Conversation

mykola-mokhnach
Copy link

@mykola-mokhnach mykola-mokhnach commented Feb 21, 2023

In recent Xcode SDKs Apple has deprecated the recordFailureWithDescription method of XCTestCase and replaced it with the recordIssue one.

Copy link
Collaborator

@Dan-Maor Dan-Maor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Xcode 13.2.1 and 14.2, looks good (cannot run on 12 since I've upgraded to Ventura).

@mykola-mokhnach mykola-mokhnach merged commit cafe47e into master Feb 22, 2023
@mykola-mokhnach mykola-mokhnach deleted the patch_issue branch February 22, 2023 09:09
github-actions bot pushed a commit that referenced this pull request Feb 22, 2023
## [4.12.2](v4.12.1...v4.12.2) (2023-02-22)

### Miscellaneous Chores

* Make sure the test is never going to be unexpectedly interrupted ([#664](#664)) ([cafe47e](cafe47e))
@github-actions
Copy link

🎉 This PR is included in version 4.12.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants