Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update keyboard typing implementation #832

Merged
merged 6 commits into from
Jan 6, 2024
Merged

Conversation

mykola-mokhnach
Copy link

Apple did major changes to the typing implementation since Xcode 13

@mykola-mokhnach
Copy link
Author

@Dan-Maor I believe we may also bump the default value of typing frequency, which currently equals to 60.
According to https://stackoverflow.com/questions/37282350/how-to-speed-up-ui-test-cases-in-xcode setting it to higher numbers may lead to an instant, but flaky text input.
Maybe there is a way to get the value used by xctest itself?

@KazuCocoa
Copy link
Member

Will take a look tomorrow or the next (just a note)

Copy link
Collaborator

@Dan-Maor Dan-Maor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will investigate regarding XCTest’s default value on Sunday.

WebDriverAgentLib/Commands/FBElementCommands.m Outdated Show resolved Hide resolved
Copy link
Collaborator

@Dan-Maor Dan-Maor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg. I have tested on a tvOS device as well, which has no focus.

+ (NSUInteger)defaultTypingFrequency
{
NSInteger defaultFreq = [[NSUserDefaults standardUserDefaults]
integerForKey:@"com.apple.xctest.iOSMaximumTypingFrequency"];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mykola-mokhnach mykola-mokhnach merged commit 06cfb3b into master Jan 6, 2024
44 of 46 checks passed
@mykola-mokhnach mykola-mokhnach deleted the type_upd branch January 6, 2024 09:14
github-actions bot pushed a commit that referenced this pull request Jan 6, 2024
## [5.15.6](v5.15.5...v5.15.6) (2024-01-06)

### Miscellaneous Chores

* Update keyboard typing implementation ([#832](#832)) ([06cfb3b](06cfb3b))
Copy link

github-actions bot commented Jan 6, 2024

🎉 This PR is included in version 5.15.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants