Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unused capabilities #871

Merged
merged 3 commits into from
Oct 18, 2023
Merged

chore: Remove unused capabilities #871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24cbbd8
chore: Remove unused capabilities
mykola-mokhnach Oct 18, 2023
520ba58
moar
mykola-mokhnach Oct 18, 2023
b72e612
Fix lint
mykola-mokhnach Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/commands/context.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,10 +436,12 @@ const ContextMixin = {
},

async setupNewChromedriver(opts, curDeviceId, adb, context) {
// @ts-ignore TODO: Remove the legacy
if (opts.chromeDriverPort) {
this?.log?.warn(
`The 'chromeDriverPort' capability is deprecated. Please use 'chromedriverPort' instead`
);
// @ts-ignore TODO: Remove the legacy
opts.chromedriverPort = opts.chromeDriverPort;
}

Expand Down
28 changes: 0 additions & 28 deletions lib/constraints.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,6 @@ export const ANDROID_DRIVER_CONSTRAINTS = {
deviceReadyTimeout: {
isNumber: true,
},
androidCoverage: {
isString: true,
},
androidDeviceReadyTimeout: {
isNumber: true,
},
Expand Down Expand Up @@ -87,11 +84,6 @@ export const ANDROID_DRIVER_CONSTRAINTS = {
enableWebviewDetailsCollection: {
isBoolean: true,
},
// this one is deprecated
chromeDriverPort: {
isNumber: true,
},
// duplicate of above with better spelling
chromedriverPort: {
isNumber: true,
},
Expand Down Expand Up @@ -143,9 +135,6 @@ export const ANDROID_DRIVER_CONSTRAINTS = {
unicodeKeyboard: {
isBoolean: true,
},
resetKeyboard: {
isBoolean: true,
},
noSign: {
isBoolean: true,
},
Expand All @@ -158,12 +147,6 @@ export const ANDROID_DRIVER_CONSTRAINTS = {
nativeWebScreenshot: {
isBoolean: true,
},
androidScreenshotPath: {
isString: true,
},
androidInstallPath: {
isString: true,
},
clearSystemFiles: {
isBoolean: true,
},
Expand All @@ -173,9 +156,6 @@ export const ANDROID_DRIVER_CONSTRAINTS = {
autoGrantPermissions: {
isBoolean: true,
},
sharedPreferences: {
isObject: true,
},
networkSpeed: {
isString: true,
},
Expand Down Expand Up @@ -270,17 +250,9 @@ export const ANDROID_DRIVER_CONSTRAINTS = {
allowDelayAdb: {
isBoolean: true,
},

/*-----------------------------------+
| UI-AUTOMATOR-SPECIFIC CONSTRAINTS |
+-----------------------------------+*/

ignoreUnimportantViews: {
isBoolean: true,
},
acceptSslCerts: {
isBoolean: true,
},
disableWindowAnimation: {
isBoolean: true,
},
Expand Down
Loading