Always emit the close event

appium · Mar 29, 2020 · 18369cc · 18369cc
1 parent 6391ac1
commit 18369cc
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/lib/express/idempotency.js b/lib/express/idempotency.js
@@ -33,7 +33,9 @@ function cacheResponse (key, req, res) {
     responseStateListener,
   });
   const tmpFile = path.resolve(os.tmpdir(), `${util.uuidV4()}.response`);
-  const responseListener = fs.createWriteStream(tmpFile);
+  const responseListener = fs.createWriteStream(tmpFile, {
+    emitClose: true,
+  });
   const originalSocketWriter = res.socket.write.bind(res.socket);
   const patchedWriter = (chunk, encoding, next) => {
     responseListener.write(chunk);
@@ -54,7 +56,7 @@ function cacheResponse (key, req, res) {
       responseListener.end();
     }
   });
-  responseListener.once('finish', () => {
+  responseListener.once('close', () => {
     if (!IDEMPOTENT_RESPONSES.has(key)) {
       const msg = `Could not cache the response identified by '${key}'. ` +
         `Cache consistency has been damaged`;