This repository has been archived by the owner on Oct 25, 2023. It is now read-only.
feat: Allow single zip bundle to contain multiple app SDK builds #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
chore: Lint changes
nextlevelbeard
force-pushed
the
zip_app_multiple_sdks
branch
from
885057a to
b72e902
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case: A user configures the
appcapability with a.zipfile.The file contains builds at the same revision for multple SDKs, simulator and device, therefore it contains at the root both an
.ipaand.appfile.Previously, If there were multiple tests running, they would all reuse the same cached application file that was first unzipped. This means that if the first test was on a real device and the second test ran on a simulator, the cached application became the unzipped
.ipafile, producing abad apperror when testing on the simulator. And vice-versa.This change first tries to configure the app with the proper
supportedAppExtensions(as it was already previously doing) and when it errors detecting the different desired extension, Appium will look inside the.ziparchive again for a file with the correct extension.To fully allow for this is, the XCUITest driver also needs this tiny change appium/appium-xcuitest-driver#1408